Support some action buttons in the UserProfileSlidingPane. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring/unignoring a user does actually work, but the timelines are automatically cleared by the Matrix SDK, which Robrix currently doesn't handle very well. Also, the newly re-fetched `RoomMember` object for the ignored user does NOT actually reflect that the user has been ignored, i.e., the `RoomMember::is_ignored()` function still returns the old state. Not sure how to fix that yet, but I am asking around.
…uired afterwards, but there is no way to currently do that in the Matrix SDK. So, while the logic for sending the (un)ignore request and handling the response are all correct, the timelines get completely cleared and we don't yet know how to re-establish them (perform that full sync). There is a related GitHub issue here, but it has been stagnant for a long time: <matrix-org/matrix-rust-sdk#1703> Relevant message from the Matrix SDK chat room: <https://matrix.to/#/!qSsPTKDfMGYqhgiLPJ:flipdot.org/$hCVXmEJh4EvbT2puuSxuv4rgnzXbQ6R07NJyT6VVwKQ?via=flipdot.org&via=matrix.org&via=element.io>
kevinaboos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring/unignoring a user does actually work, but the timelines are automatically cleared by the Matrix SDK, which Robrix currently doesn't handle very well.
Also, the newly re-fetched
RoomMemberobject for the ignored user does NOT actually reflect that the user has been ignored, i.e., theRoomMember::is_ignored()function still returns the old state. Not sure how to fix that yet, but I am asking around.