Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Memory Breakpoints (MBP) Debugging #184

Open
wants to merge 6 commits into
base: slippi
Choose a base branch
from
Open

Fix Memory Breakpoints (MBP) Debugging #184

wants to merge 6 commits into from

Conversation

rapito
Copy link
Contributor

@rapito rapito commented Aug 20, 2020 •
edited
Loading

This fixes the following:

  • Adding/Removing a memory breakpoint will now properly pause when on.
  • Adding/Removing a memory breakpoint while the game is running no longer crashes dolphin.
  • Adding/Removing a memory breakpoint now properly updates the table entries on the breakpoints tab.
  • DebugFast and Debug configurations can now be built using Visual Studio.

Things to know:

  • Use DebugFast run configuration instead of Debug since it will run the game a lot faster than Debug (which is very slow).
  • If you build any Release Configuration then you must rebuild the whole solution (I think) on DebugFast to be able to hit breakpoints again. (I got too tired to figure this out)
    i.e:
    • Build DebugFast: breakpoints are working properly
    • Build Release
    • Build DebugFast again: breakpoints no longer work.
    • Rebuild Solution in DebugFast: breakpoints are working again.

rapito added 5 commits August 20, 2020 02:08
@rapito
Refresh Breakpoint list when memory breakpoint is added
12368e7
@rapito
Toggle Breakpoint with proper range
e0ce724 
Use proper range depending on the data type when adding a breakpoint.
@rapito
Fix Breakpoints from crashing dolphin while running
83327ce 
+ Always Break when a memcheck is hit
+

Mergeback from mainline
-  Add Breakpoints on a CPU thread
@rapito
Update MMU.cpp
4c8736d 
+ Use mainline memchecks instead of commented out code (actually hit a breakpoint)
@rapito
Update sln project settings to allow building DebugFast
43e5866 
+ Use 142 buildtools as all other projects
+ pass in -d argument to dolphin on run
@rapito
Update MMU.cpp
58cc0b8 
Don't Memcheck if disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLaferri JLaferri JLaferri left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rapito @JLaferri