Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upstream merge to 2412 #32

Open
wants to merge 328 commits into
base: slippi
Choose a base branch
from
Open

Conversation

NikhilNarayana
Copy link
Member

No description provided.

JosJuice and others added 30 commits September 28, 2024 13:43
So far, Dolphin hasn't been able to run on Android devices that use a
16 KiB page size. 16 KiB page sizes are a very new Android feature that
no phones have shipped with so far, so we're still compatible with the
phones that exist out there, but let's get this fixed before phones
start shipping with 16 KiB page sizes.

Because I couldn't get Android Studio's emulator to work, I haven't been
able to confirm that this change actually makes Dolphin fully compatible
with devices that use a 16 KiB page size. But I have confirmed that this
doesn't break anything on a regular 4 KiB page size device.
Dolphin has been using edge-to-edge rendering for a little while now,
but it has required a bit of manual work. Now that edge-to-edge is
becoming something expected of apps in Android 15, there's a nicer API
we can use.

Tested on Android 8, 11 and 13, with no changes in behavior noted.
These codes are actually Gecko codes so setting that correctly.

There were errors which pop up when running this game as the comments for AR codes need to be set with hash(#) instead of asterisk(*). I replaced those anyways.

Removed the url in the comment since it's inaccessible and not on wayback machine either.

Also corrected the GameID, the wrong one is listed.
Both UseXFB and UseRealXFB are obsolete since Hybrid XFB.
Hack is not a valid setting.

Also updated the GameID.
The wrong filename was used so the settings weren't being applied.

(All it does is reset the Texture Cache Accuracy to the default setting.)
The use of any anti-aliasing will cause graphical corruption, which occurs on the ground.

MaxAnisotropy is supposed to be for [Video_Enhancements], but also it doesn't cause any of the issues in game so it is being removed rather than set under the correct heading.

Added a comment on why these values are set.
…r: The Ultimate Fitness System

SafeTextureCacheColorSamples is supposed to be for [Video_Settings], but also the medium setting isn't enough to display the missing text.
When HLE-ing the apploader, this is necessary to avoid "Error #2"
errors. Homebrew doesn't care.
This runtime assertion was added before `std::is_sorted` became constexpr in the codebase.
VolumeVerifier: Promote `DEBUG_ASSERT` to `static_assert`
Boot: write Apploader version into memory
It defaults to trying to emulate simdgroup functions on iOS
…nament"

This is required to avoid glitches during Downhill Skiing.
SIMD-scoped permute operations are Apple6, but reduction operations are Apple7
This reverts commit 6dad8f8.

Our bundled zlib-ng uses zlib compat mode, making it override system zlib.
System zlib-ng will not, and all its functions will be prefixed with zng_.
Therefore the two aren't actually compatible.
VideoCommon: Dirty pixel shader manager on efb scale changes
…_mistakes_part_2

GameINI: Fixing More Mistakes
…ements-fail-messaging

Achievements Fail Messaging
VideoBackends:Vulkan: Prevent freezes during window resize on Linux
AchievementManager::SetHardcoreMode now handles the (non-Qt) settings disabled by hardcore mode, instead of doing this on the Qt layer. Also ensured Init/Enable Achievements paths run this code, fixing the bug wherein the player can manipulate things when achievements are disabled that persist when turned back on.
Found this bug while testing; if I manually edit the config files while Dolphin is closed I was able to get debug and hardcore on at the same time, this resolves that.
Bluetooth: show vid:pid in error message
cpba and others added 28 commits November 10, 2024 12:06
this version bundles SDL2-2.30.6, the temporary measure of building the
vendored version from exports is no longer necessary.
If the host is in hardcore mode, all joining players will be set to hardcore mode; if not, all joining players will be set to softcore. This ensures all players have the same settings and remain synchroized.
…g-none

docs: Clarify wia_except_list_t padding in uncompressed groups
ProcessorInterface: sync GPU just before PI_FIFO_RESET
…eakpoints

GDBStub: Signal Breakpoint Changes To Host
ControllerInterface/SDL: Disable SDL's Windows.Gaming.Input controller handling.
Fix Kirby's Adventure Wii Metafortress bypass patch
…ements-netplay-hardcore

Force NetPlay Clients to Host Hardcore Status
…-hunts-2011-safe-texture-cache

GameINI: Use Safe Texture Cache for Cabela's Dangerous Hunts 2011
The read thread could call Reset, which in turn tried to join the read
thread, leading to a SIGABRT. This manifested as Dolphin consistently
crashing when disconnecting a GC adapter and having a chance of crashing
a few seconds after connecting a GC adapter.
…reset

Android/GCAdapter: Don't join current thread
@NikhilNarayana
Copy link
Member Author

two notable issues so far

  • Windows
    • crashes on game startup
  • Linux
    • crashes when interacting with the main window after starting the game

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.