Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player profile links to the replay browser #450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juebjueb
Copy link

Follow up on PR #375 authored by trstruth.

image

Addressing comments from vinceau:

  1. The inconsistent behaviour of some badges being clickable and some not is quite jarring.
  2. It occupies the badge click functionality in case we wanted to use that behaviour for something else in the future.
  3. The PlayerBadge which should be a dumb component now also has to handle the click function which is undesirable. I'd rather leave that to the parent.
  1. Added an explicit button to eliminate confusion for which badges are clickable.
  2. I agree that a pop-up menu would be nice to allow further extension, but I worry this would be premature. There hasn't been much activity on the replay browser over the last year, and I wouldn't want there to be a menu that's only populated with one item for a long period of time.
  3. Moved from PlayerBadge to its parent TeamElements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant