press Z to swap Zelda/Shiek in Online CSS #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-zilch
reviewed
Jan 6, 2023
| @@ -249,6 +249,15 @@ lbz r3, MSRB_IS_LOCAL_PLAYER_READY(r3) | |||
| cmpwi r3, 0 | |||
| bne FN_SZThink_CHANGE_HANDLING_END # No changes when locked-in | |||
|
|
|||
| # Check if the Z button was pressed this frame | |||
| load r4, 0x804c20bc | |||
| lbz r3, -0x49B0(r13) # player index | |||
There was a problem hiding this comment.
nitpick: use secondaryDmaBuffer
slippi-ssbm-asm/Common/Common.s
Line 604 in 65f9064
jordan-zilch
reviewed
Jan 6, 2023
| # Check if the Z button was pressed this frame | ||
| load r4, 0x804c20bc | ||
| lbz r3, -0x49B0(r13) # player index | ||
| mulli r3, r3, 68 |
There was a problem hiding this comment.
nitpick: use a constant like PLAYER_PAD_STRUCT_LEN or something (idk exactly what struct youre looking at) instead of a magic number
|
That code was copied from the code slightly below that checks for A button presses while hovering over the S/Z button. I don't know specifically what it is accessing. I can change both places? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone in Discord requested this: https://discord.com/channels/328261477372919811/1042515294268178433/1042515294268178433
Z is already used for backing out of queue so maybe a different button might be better?
This also skips the hover-check code so if you are hovering over the button that you are switching away from with Z, the button will be gray for a frame before becoming white.
Happy to fix either of those or anything else you suggest.