Fix small memory leak on chat. #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn cleanup properly. + Change cleanup order of Systext to prevent leaks + Free several allocated objects that were never freed + Refactor some methods to return the effective used attribute instead of a full object pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Results
Memory is not leaking now, so the issue is fixed, however, It seems like the game allocates some space on the initial load of JOBJs and Text structs that we can never recover unless we get real annoyed by it.
I spent some time trying to figure it out but it seems like it's just a cache thing.
The actual memory seems to now decrease any further after the initial load.