Display rank information on ranked CSS #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with Ishiiruka project-slippi/Ishiiruka#391
Overview:
The game sends an EXI command to dolphin to get the rank info through a curl request. This could be changed to something more efficient that doesnt require a new request each time the user goes to the CSS. Fizzi suggested that the matchmaking service return an expected ELO change which would significantly reduce the number of requests to the server: https://discord.com/channels/328261477372919811/733158076827303997/1060705864878657606
If this is the optimal route it may also be worth returning the opponents rank when a match is found so that it can be displayed in the GamePrep scene (suggested by altf4) https://discord.com/channels/328261477372919811/733158076827303997/1060387305501769809
Currently the only rank information that is displayed is the icon and the rating ordinal. If a user hasnt completed their placement matches for the season (
ratingUpdateCount< 5) the question mark icon will be shown with a message telling them how many matches they need to play to get a rank.User without a rank:
User with a rank:
Additional Notes
There have been instances where the game has crashed when executing the curl request on the CSS (maybe something to do with running LoadMatchState at the same time?). This hasn't been happening to me recently and I've had a few people testing the build and it doesn't seem to be crashing at all for them. Hopefully someone more knowledgeable can provide some insight and this can be debugged.