Added 'Offline Maps' to Navigation Drawer #545
Conversation
Starting point for project-travel-mate#534 Added the 'Offline Maps' section to the Navigation Drawer complete with the icon. 'fragment_offlinemaps.xml' and 'OfflineMapsFragment.java' also created.
| @@ -233,7 +233,9 @@ private Fragment getFragmentByNavMenuItemId(int id) { | |||
| case R.id.nav_utility: | |||
| fragment = UtilitiesFragment.newInstance(); | |||
| break; | |||
|
|
|||
| //Work In Progress Offline Maps | |||
There was a problem hiding this comment.
is it work in progress or done?
There was a problem hiding this comment.
Still a work in progress for the MainActivity.java file as I'm still trying to figure out how the feature should be implemented.
There was a problem hiding this comment.
@Swati4star Hey, just cleaned up this branch for the merging process. Please review it again, thanks!
| @@ -182,7 +182,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat | |||
|
|
|||
| mCityAdapter.updateData(mCities); | |||
|
|
|||
| if (mSpotlightShownCount <= 3) { | |||
| if (mSpotlightShownCount <= 4) { | |||
There was a problem hiding this comment.
My bad, this was an experimentation I was doing on trying to solve the #539 issue.
Implemented the changes as requested by the discussion in project-travel-mate#545.
|
@jtj9817 You have opened a number of PRs. Let's start merging them one by one. and is it still a work in progress? If yes, lets be done with this. (either close it or make it ready to be merged) |
|
@jtj9817 Are you going to clean it up? |
|
Sorry @Swati4star for the late reply but yes I'm going to clean this one up, just been busy with school for this past week. |
Reverted previous minor change to layout orientation
|
Instead of png, you should use an xml drawable file |
Will try to convert the PNG to a vector asset. Probably a day. |
Offline Maps icon now uses vector image asset
|
@Swati4star Just made the recent suggestion that you requested. I hope it's good for a merge now, thanks! |
These diagrams are added automatically using SimpleUMLCE. SimpleUMLCE is installed as a plug-in for Android Studio and enables automatic creation of UML files by selecting the appropriate target files.
Description
Starting point for the features requested in #534 .
Changes
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist:
Screenshot