Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIGENG-324: MA - Prototype RBAC / Add 403 Error Page #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

MIGENG-324: MA - Prototype RBAC / Add 403 Error Page #76

wants to merge 3 commits into from

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Feb 10, 2020 •
edited
Loading

https://issues.redhat.com/browse/MIGENG-324

Added 403 Error Page:

Screenshot from 2020-02-10 10-16-17

NOTE: For now there is no way we can see this page in MA since all users have full access

@carlosthe19916 carlosthe19916 added the Ready for review The PR is ready to be reviewed label Feb 10, 2020
@codecov-io
Copy link

codecov-io commented Feb 10, 2020 •
edited
Loading

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   72.84%   72.84%           
=======================================
  Files          38       38           
  Lines         906      906           
  Branches      174      174           
=======================================
  Hits          660      660           
  Misses        225      225           
  Partials       21       21
Impacted Files Coverage Δ
...tionalComponents/ReportViewPage/ReportViewPage.tsx 89.74% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17142aa...d17049e. Read the comment docs.

@carlosthe19916 carlosthe19916 added Work In Progress The code in the PR is not finished yet and removed Ready for review The PR is ready to be reviewed labels Apr 7, 2020
@mrizzi mrizzi added On hold Code is ready but we have to wait before merging it Ready for review The PR is ready to be reviewed and removed Work In Progress The code in the PR is not finished yet labels Apr 9, 2020
mrizzi
mrizzi reviewed Apr 9, 2020
View reviewed changes
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"On hold" because, right now, there's no need for such a page.
Once we will have more constraints and a way to test this, this PR will be reviewed.

@mrizzi mrizzi removed the Ready for review The PR is ready to be reviewed label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizzi mrizzi mrizzi left review comments

Assignees
No one assigned
Labels
On hold Code is ready but we have to wait before merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosthe19916 @codecov-io @mrizzi