feat(storage): enable parallel writes by using per-repo locking #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
force-pushed
the
storage
branch
2 times, most recently
from
8aa74db
to
b6d386c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
- Coverage 92.69% 92.68% -0.01%
==========================================
Files 169 170 +1
Lines 22523 22556 +33
==========================================
+ Hits 20878 20907 +29
- Misses 1026 1027 +1
- Partials 619 622 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrei Aaron <[email protected]>
Signed-off-by: Andrei Aaron <[email protected]>
andaaron
force-pushed
the
storage
branch
2 times, most recently
from
7343d22
to
f23ccb3
Compare
Signed-off-by: Andrei Aaron <[email protected]>
Remove the logic to discard unused locks as it produced deadlocks Signed-off-by: Andrei Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic POC. Need to get it working first.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.