-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-862k43hfa - Add circuit and decouple viewmodel from view #127
CU-862k43hfa - Add circuit and decouple viewmodel from view #127
Conversation
1bd7400
to
9911935
Compare
import io.newm.feature.login.screen.createaccount.signupform.SignupFormUiEvent | ||
|
||
sealed interface CreateAccountUiState : CircuitUiState { | ||
data class SignupForm( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, curious with this approach will we be able to reuse states like Loading, Error or will those states have to exist within CreateAccountUiState seal class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could technically reuse them, but the overhead is not worth it
import io.newm.feature.login.screen.password.ConfirmPasswordState | ||
import io.newm.feature.login.screen.password.PasswordState | ||
|
||
class CreateAccountPresenter : Presenter<CreateAccountUiState> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never heard about this Circuit library before. They should have used a different name instead of Presenter
, because of all the old MVP architecture baggage. Or is Circuit really Mvp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's MVP with unidirectional data flow
No description provided.