CU-862k43hfa - Add circuit and decouple viewmodel from view #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmskywalker
force-pushed
the
jm/CU-862k43hfa_Add-circuit-and-decouple-viewmodel-from-view
branch
from
1bd7400
to
9911935
Compare
| import io.newm.feature.login.screen.createaccount.signupform.SignupFormUiEvent | ||
|
|
||
| sealed interface CreateAccountUiState : CircuitUiState { | ||
| data class SignupForm( |
There was a problem hiding this comment.
This looks great, curious with this approach will we be able to reuse states like Loading, Error or will those states have to exist within CreateAccountUiState seal class?
There was a problem hiding this comment.
We could technically reuse them, but the overhead is not worth it
cristhianescobar
approved these changes
Jul 11, 2023
wlara
reviewed
Jul 12, 2023
| import io.newm.feature.login.screen.password.ConfirmPasswordState | ||
| import io.newm.feature.login.screen.password.PasswordState | ||
|
|
||
| class CreateAccountPresenter : Presenter<CreateAccountUiState> { |
There was a problem hiding this comment.
Never heard about this Circuit library before. They should have used a different name instead of Presenter, because of all the old MVP architecture baggage. Or is Circuit really Mvp?
There was a problem hiding this comment.
It's MVP with unidirectional data flow
newmskywalker
deleted the
jm/CU-862k43hfa_Add-circuit-and-decouple-viewmodel-from-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.