Add feature flag support using launchdarkly #336
Conversation
| e | ||
| ) | ||
| } finally { | ||
| launchHomeActivity() |
There was a problem hiding this comment.
Nice, so we will always attempt to fetch the FF, but if it fails we will use default values.
There was a problem hiding this comment.
Yeah, if we're unable to target this specific user, they will be targeted by the other rules we've defined in launchdarkly
|
|
||
| object FeatureFlags { | ||
| object MarketPlace : FeatureFlag { | ||
| override val key = "streams-marketplace" |
There was a problem hiding this comment.
Should we set a default for this FF? Curious how we will handle the situation where feature flags were not fetched? I assume we use default values, and if so should those be declared here along with the key?
There was a problem hiding this comment.
The default value is passed when evaluating the flag. Boolean flags (the only ones we currently support) default to false but this can be changed by the caller to FeatureFlagManager
|
@newmskywalker can you add me to LD when you get a chance please. |
newmskywalker
deleted the
sky/add_feature_flag_manager_using_launch_darkly
branch
No description provided.