imagefactory: Automatically substitute kickstart --url argument #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fedora-atomic kickstarts reference Koji-generated ostreesetup URLs. Whereas often, I want to generate a tree locally, then have the cloud images use that. If we're taking the viewpoint that official rel-eng for images uses Koji, then the kickstarts are fine, and -toolbox can be more of a developer and "single integration server" tool.
|
Background on this change: the kickstart files now live in https://git.fedorahosted.org/git/spin-kickstarts.git - so we're not using |
|
@cgwalters Looks good now. Thumbs up from me. |
|
I spent a little bit of time trying to merge this with master but all of the cases are making my head hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fedora-atomic kickstarts reference Koji-generated ostreesetup
URLs. Whereas often, I want to generate a tree locally, then have the
cloud images use that.
If we're taking the viewpoint that official rel-eng for images uses
Koji, then the kickstarts are fine, and -toolbox can be more of a
developer and "single integration server" tool.