Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow autocomplete items to wrap. Otherwise, very long suggestions can bleed off the screen. #1428

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

lfarrell
Copy link
Contributor

PR for #1383

Fixes issue with autocomplete options bleeding off the side of the screen. It restricts the autocomplete options to the width of the search input it is providing options for. See issue above for screenshots of the original issue.

@seanaery
Copy link
Contributor

seanaery commented Dec 6, 2023

This looks good @lfarrell -- I can see it working when I run locally.
typeahead-width-1-before
typeahaed-width-2-after

Just one suggested change: rather than tacking this change onto modules/layout.scss which is growing lengthy, can you create a modules/search_form.scss for it, then @import it in application.scss?

@lfarrell lfarrell force-pushed the autocomplete-wrapper branch from 0e6e14c to d32bef8 Compare December 6, 2023 20:25
@marlo-longley marlo-longley merged commit 0d73b63 into main Dec 7, 2023
4 checks passed
@marlo-longley marlo-longley deleted the autocomplete-wrapper branch December 7, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants