Backport #3367 to 8.x (Add a way to filter facets in the facets "more" modal) #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
force-pushed
the
backport-facet-suggest-to-8
branch
from
46452d2 to
390d831
Compare
sandbergja
changed the title
sandbergja
changed the title
sandbergja
changed the title
cbeer
reviewed
Oct 21, 2024
cbeer
reviewed
Oct 21, 2024
cbeer
reviewed
Oct 21, 2024
cbeer
reviewed
Oct 21, 2024
* Facet typeahead: back end This creates a new endpoint at /catalog/facet/<facet_name>/<query_fragment> Co-authored-by: Isha Sinha <[email protected]> * Facet typeahead: front end Co-authored-by: Christina Chortaria <[email protected]> * bundle exec i18n-tasks add-missing * Incorporate feedback from review Rather than two very similar controller actions for facets vs. facet_suggest, this commit combines them into a single controller action. --------- Co-authored-by: Isha Sinha <[email protected]> Co-authored-by: Christina Chortaria <[email protected]>
Co-authored-by: Chris Beer <[email protected]>
Co-authored-by: Chris Beer <[email protected]>
sandbergja
force-pushed
the
backport-facet-suggest-to-8
branch
2 times, most recently
from
bc4e53b to
efab330
Compare
* Make this feature opt-in. You can add suggest: true to your facet config in the catalog controller to start using it. * Use text_field_tag
sandbergja
force-pushed
the
backport-facet-suggest-to-8
branch
from
efab330 to
2d91574
Compare
maxkadel
reviewed
Dec 3, 2024
There was a problem hiding this comment.
This looks awesome! Thank you @sandbergja!
My only hesitation is about the translations and what our expectations are around including language translations, or just making sure the "no translation" error doesn't render in any languages.
| // const basicFunction = (entry) => console.log(entry) | ||
| // const debounced = debounce(basicFunction("I should only be called once")); | ||
| // | ||
| // debounced // does NOT print to the screen becase it is invoked again less than 200 milliseconds later |
| @@ -111,6 +111,9 @@ ar: | |||
| sort: | |||
| count: ترتيب رقمي | |||
| index: ترتيب أبجدي | |||
| suggest: | |||
There was a problem hiding this comment.
Is it expected that these be in the target language? Or is it ok to start with English and then have a future edit with the real translation?
There was a problem hiding this comment.
Thanks for pointing this out. It looks like I used the add_missing task from i18n-tasks, when I should have used translate_missing, which grabs a preliminary translation from Google Translate.
Co-authored-by: Max Kadel <[email protected]>
This pulls preliminary translations from the Google Cloud Translate API
maxkadel
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Thanks @sandbergja! Looks good! Happy to know about the "translate missing" task as well
maxkadel
approved these changes
Dec 17, 2024
|
Thanks @sandbergja 💯 -- this is such a useful feature and I'm glad to see it'll be available in 8.x! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the "more" facet modal filter feature to the 8.x series (see #3367 for the 9.x version)