Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClausePresenter: don't attempt to call #display_label on a non-existant field configuration #3442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ClausePresenter: don't attempt to call #display_label on a non-existant field configuration #3442

wants to merge 1 commit into from

Conversation

sandbergja
Copy link
Contributor

closes #3441

@sandbergja sandbergja mentioned this pull request Nov 11, 2024
Closed
sandbergja added a commit to pulibrary/orangelight that referenced this pull request Nov 11, 2024
@sandbergja
[#4554] ClausePresenter: don't attempt to call #display_label on a no…
567bf37 
…n-existant field configuration

This fixes an error that appeared when a user specified a search field that
does not exist.  It is essentially the same as upstream fix projectblacklight/blacklight#3442,
so if that is accepted and we start using a Blacklight release that includes
it, we can remove our customized version.
@sandbergja sandbergja mentioned this pull request Nov 11, 2024
Merged
kevinreiss pushed a commit to pulibrary/orangelight that referenced this pull request Nov 11, 2024
@sandbergja
[#4554] ClausePresenter: don't attempt to call #display_label on a no…
4e84f4f 
…n-existant field configuration (#4559)

This fixes an error that appeared when a user specified a search field that
does not exist.  It is essentially the same as upstream fix projectblacklight/blacklight#3442,
so if that is accepted and we start using a Blacklight release that includes
it, we can remove our customized version.
jcoyne
jcoyne requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handles the failure silently, but shouldn't this result in a 401 Bad Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne jcoyne requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClausePresenter throws a NoMethodError when user tries to search a non-existant field
2 participants
@sandbergja @jcoyne