Merge pull request #3319 from projectblacklight/jcoyne-patch-2

Improve semantic markup of breadcrumbs.

app/components/spotlight/breadcrumbs_component.html.erb

@@ -1,19 +1,13 @@
-<div class="container breadcrumbs-container" role="navigation" aria-label="<%= t('spotlight.breadcrumb.label') %>">
-  <div class="row">
-    <div class="col-md-12">
-      <nav>
-        <ul class="breadcrumb list-unstyled d-flex">
-          <% breadcrumbs.each do |crumb| %>
-          <li class="breadcrumb-item <%= crumb == breadcrumbs.last ? 'active' : '' %>">
-            <% if crumb.link? && crumb != breadcrumbs.last %>
-              <%= link_to crumb.name, path(crumb.path) %>
-            <% else %>
-              <%= crumb.name %>
-            <% end %>
-          </li>
-          <% end %>
-        </ul>
-      </nav>
-    </div>
-  </div>
-</div>
+<nav class="container breadcrumbs-container" aria-label="<%= t('spotlight.breadcrumb.label') %>">
+  <ol class="breadcrumb">
+    <% breadcrumbs.each do |crumb| %>
+    <li class="breadcrumb-item <%= crumb == breadcrumbs.last ? 'active' : '' %>">
+      <% if crumb.link? && crumb != breadcrumbs.last %>
+        <%= link_to crumb.name, path(crumb.path) %>
+      <% else %>
+        <%= crumb.name %>
+      <% end %>
+    </li>
+    <% end %>
+  </ol>
+</nav>

spec/features/browse_category_navigation_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe 'Browse pages' do
+RSpec.describe 'Browse pages' do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let!(:search) { FactoryBot.create(:search, title: 'Some Saved Search', exhibit:, published: true) }
   let!(:search_2) { FactoryBot.create(:search, title: 'Some Other Saved Search', exhibit:, published: true) }
@@ -37,7 +37,7 @@
         expect(page).to have_css 'li.nav-item a.nav-link.active', text: group.title
       end
       click_link 'Some Saved Search'
-      expect(page).to have_css 'ul.breadcrumb li.breadcrumb-item', count: 4
+      expect(page).to have_css 'ol.breadcrumb li.breadcrumb-item', count: 4
       expect(page).to have_css 'li.breadcrumb-item', text: 'Awesome group'
     end
   end