Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAJOR] Make clipboard and leaflet dependencies for NPM #2885

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Feb 15, 2023

The rails version of clipboard is out of date with the javascript version and hasn't been updated in 6 years.

This allows moving away from sprockets (importmap-rails) if desired.

This requires the host application to pull in the npm dependencies or re-run the spotlight generator.

@jcoyne jcoyne force-pushed the clipboard branch 2 times, most recently from e603120 to eff600e Compare February 15, 2023 15:10
@jcoyne jcoyne changed the title Make the clipboard dependency an NPM dependency Make clipboard and leaflet dependencies for NPM Feb 15, 2023
@jcoyne jcoyne force-pushed the clipboard branch 2 times, most recently from be36840 to 2033e5e Compare February 15, 2023 20:07
The rails version is out of date with the javascript version and hasn't been updated in 6 years
@jcoyne jcoyne changed the title Make clipboard and leaflet dependencies for NPM [MAJOR} Make clipboard and leaflet dependencies for NPM Feb 16, 2023
@jcoyne jcoyne changed the title [MAJOR} Make clipboard and leaflet dependencies for NPM [MAJOR] Make clipboard and leaflet dependencies for NPM Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant