Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the class argument to serialize as a keyword #3010

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 30, 2024

The positional argument is deprecated and will be removed in rails 7.2

@jcoyne jcoyne force-pushed the class-as-keyword branch 4 times, most recently from e3ab923 to 3bfac50 Compare January 30, 2024 17:10
@jcoyne jcoyne force-pushed the class-as-keyword branch from 3bfac50 to 37e5b73 Compare June 21, 2024 13:36
The positional argument is deprecated and will be removed in rails 7.2
@corylown corylown force-pushed the class-as-keyword branch from 37e5b73 to c13d76e Compare July 2, 2024 18:23
@corylown
Copy link
Contributor

corylown commented Jul 2, 2024

It looks like the method signature for ActiveRecord::AttributeMethods::Serialization::ClassMethods#serialize changed to accept keyword arguments with Rails 7.1 not 7.0 so I'm updating this PR to reflect that.

Rails 7.0
Rails 7.1

@taylor-steve taylor-steve merged commit 9ed6da6 into main Jul 2, 2024
8 checks passed
@taylor-steve taylor-steve deleted the class-as-keyword branch July 2, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants