Add a view component for tagging, replacing bootstrap-tagsinput #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylor-steve
force-pushed
the
stimulus-tags
branch
2 times, most recently
from
6ee6e2c
to
f58de16
Compare
taylor-steve
changed the title
|
Looking for feedback on if my changes (the ability to add a new tag on the fly) to the original, good widget that I adapted ruin it. Sometimes I think it makes it a bit unwieldly, but it is functional. If people think this is okay to use in this way, Alan wanted a demo or a push to stage for final say. |
taylor-steve
force-pushed
the
stimulus-tags
branch
from
f58de16
to
e1eebee
Compare
corylown
reviewed
Sep 16, 2024
| private | ||
|
|
||
| def bootstrap_version | ||
| bootstrap_gem = Gem.loaded_specs['bootstrap'] |
There was a problem hiding this comment.
In other places in Spotlight we've added the visually-hidden class to the close button so it will appear for BS4 and not BS5. Would that be possible here too so we don't have to check the version of the installed gem?
|
Would it be better to use the tag UI that @dnoneill developed for Argo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible solution for #2890
A variation on the code mentioned in #3074 in another attempt to remove the dependency on bootstrap-tagsinput. Supports the same input scheme as bootstrap-tagsinput, but does have a different look and feel.