remove tophat #3253
Open
remove tophat #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnoneill
force-pushed
the
remove-tophat
branch
from
6af8416
to
54a2379
Compare
dnoneill
force-pushed
the
remove-tophat
branch
from
54a2379
to
f8c7958
Compare
dnoneill
commented
Nov 5, 2024
| @@ -30,7 +30,6 @@ class CatalogController < ::CatalogController | |||
| if Blacklight::VERSION > '8' | |||
| blacklight_config.show.document_component = Spotlight::DocumentComponent | |||
| else | |||
| blacklight_config.show.partials.unshift 'tophat' | |||
There was a problem hiding this comment.
I moved this into base instead. I think this is an okay way of doing this but I can change it back.
There was a problem hiding this comment.
It looks to me like for Blacklight 8 this gets handled in the Spotlight::DocumentComponent so will doing this in the base template instead cause meta content to appear twice in Blacklight 8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3052
This also fixes malforming meta tags. twitter:card should have the content in the content tag not value (which is what tophat does).