Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default chrome fix specs #3337

Merged
merged 10 commits into from
Dec 11, 2024
Merged

Default chrome fix specs #3337

merged 10 commits into from
Dec 11, 2024

Conversation

corylown
Copy link
Contributor

No description provided.

@taylor-steve taylor-steve marked this pull request as ready for review December 10, 2024 16:34
@@ -47,7 +47,7 @@
}

content = CSV.parse(response.body)
expect(content.length).to eq 56
expect(content.length).to be_within(1).of(56)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a comment why we are doing this? Why won't it equal 56?

@corylown corylown force-pushed the default-chrome-fix-specs branch from 12b9c99 to 2ddaeaf Compare December 10, 2024 22:22
@corylown corylown force-pushed the default-chrome-fix-specs branch from 2ddaeaf to 1f2a750 Compare December 10, 2024 22:37
@hudajkhan hudajkhan merged commit fed880a into main Dec 11, 2024
7 checks passed
@hudajkhan hudajkhan deleted the default-chrome-fix-specs branch December 11, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants