Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace to the exhibit_root_url helper #3343

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Add namespace to the exhibit_root_url helper #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/spotlight/meta_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def add_exhibit_meta_content
def exhibit_twitter_card_content
card('twitter') do |card|
card['card'] = 'summary'
card['url'] = exhibit_root_url(current_exhibit)
card['url'] = spotlight.exhibit_root_url(current_exhibit)
card['title'] = current_exhibit.title
card['description'] = current_exhibit.subtitle
card['image'] = meta_image if current_exhibit.thumbnail
Expand Down
2 changes: 1 addition & 1 deletion spec/helpers/spotlight/meta_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
end

it 'generates a twitter card for the exhibit' do
allow(helper).to receive(:exhibit_root_url).and_return('some/url')
allow(helper).to receive(:spotlight).and_return(double(exhibit_root_url: 'some/url'))
allow(current_exhibit).to receive(:thumbnail).and_return(double(iiif_url: 'https://test.host/images/7777/full/400,300/0/default.jpg'))

helper.add_exhibit_meta_content
Expand Down
Loading