Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Sir Trevor H1 icon to H #3352

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Change Sir Trevor H1 icon to H #3352

merged 1 commit into from
Dec 12, 2024

Conversation

taylor-steve
Copy link
Contributor

It was noticed in sul-dlss/exhibits#2677 that the Sir Trevor H1 WYSIWYG icon doesn't produce an h1 tag. It seems like some/most modern WYSIWYGs use "H". This leaves us free to change the level of the heading tag in the future without having to change the icon.

From:
Screenshot 2024-12-12 at 11 07 12 AM

To:
Screenshot 2024-12-12 at 10 48 27 AM

@jcoyne jcoyne merged commit b0f1c1b into main Dec 12, 2024
7 checks passed
@jcoyne jcoyne deleted the sir-trevor-heading-icon branch December 12, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants