-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support virtio-GPU backed by both iGPU and dGPU scanouts #100
Support virtio-GPU backed by both iGPU and dGPU scanouts #100
Conversation
Improper Commit Message |
if (ret == 0 && value & (1UL << (index + 16))) { | ||
ALOGI("wf -- set allow p2p for crtc %u, bitmask = 0x%lx\n", index, value); | ||
c->allow_p2p_ = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drmCrtc.cpp is common code, while added code is virtio-gpu specific, it is better we can move these code to virtio-gpu file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but the flag is per-CRTC and it would be handy to include it in class DrmCrtc.
Improper Commit Message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Save first shadow buffer handle and fd for destroying. * Make i915_device local to avoid race condition. Tracked-On: OAM-129252 Signed-off-by: Weifeng Liu <[email protected]>
Add a flag to the HwcLayer which will be set when the layer is allowed to be shared as local memory objects without migrating to system memory, primarily used in the case that the layer is to be displayed on dGPU. If this flag is enabled, we will set the DMA BUF name to "p2p" via DMA_BUF_SET_NAME ioctl. The name acts as a hint in the KMD for local memory sharing. This feature cannot be achieved without the help from virtio-GPU KMD: now virtio-GPU will expose a bit mask (queried by ALLOW_P2P parameter) indicating whether local memory sharing is allowed for each scan-out. Tracked-On: OAM-129252 Signed-off-by: Weifeng Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
5397937
into
projectceladon:celadon/u/mr0/master
Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/379 |
No description provided.