Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support virtio-GPU backed by both iGPU and dGPU scanouts #100

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

phreer
Copy link
Contributor

@phreer phreer commented Jan 3, 2025

No description provided.

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started labels Jan 3, 2025
@phreer phreer marked this pull request as draft January 3, 2025 04:14
if (ret == 0 && value & (1UL << (index + 16))) {
ALOGI("wf -- set allow p2p for crtc %u, bitmask = 0x%lx\n", index, value);
c->allow_p2p_ = true;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drmCrtc.cpp is common code, while added code is virtio-gpu specific, it is better we can move these code to virtio-gpu file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the flag is per-CRTC and it would be handy to include it in class DrmCrtc.

@phreer phreer marked this pull request as ready for review January 9, 2025 03:24
@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci sysopenci added PR approved and removed Pending PR Review Pending PR Review labels Jan 13, 2025
* Save first shadow buffer handle and fd for destroying.
* Make i915_device local to avoid race condition.

Tracked-On: OAM-129252
Signed-off-by: Weifeng Liu <[email protected]>
Add a flag to the HwcLayer which will be set when the layer is allowed to be
shared as local memory objects without migrating to system memory, primarily
used in the case that the layer is to be displayed on dGPU. If this flag is
enabled, we will set the DMA BUF name to "p2p" via DMA_BUF_SET_NAME ioctl. The
name acts as a hint in the KMD for local memory sharing.

This feature cannot be achieved without the help from virtio-GPU KMD: now
virtio-GPU will expose a bit mask (queried by ALLOW_P2P parameter) indicating
whether local memory sharing is allowed for each scan-out.

Tracked-On: OAM-129252
Signed-off-by: Weifeng Liu <[email protected]>
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

FAILURE: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Failed and removed Engineering Build Not Started Engineering Build Not Started labels Jan 17, 2025
@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Failed labels Jan 17, 2025
@sysopenci
Copy link

Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci merged commit 5397937 into projectceladon:celadon/u/mr0/master Jan 17, 2025
17 checks passed
@sysopenci
Copy link

Android CI has completed MERGE Build for this pr, build is SUCCESS. Please check the linked Tracked-On issue/Android CI Web for more details. For Binaries: /cactus-absp-or-local/celadon_umr0_master-merge/379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants