Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSP_DIFF cleanup #103

Closed
wants to merge 1 commit into from
Closed

BSP_DIFF cleanup #103

wants to merge 1 commit into from

Conversation

ankithbti52509
Copy link
Contributor

Updating android.hardware.graphics.composer3 hal version from V2 to V4. Also adding new apis as per hal version V4.

Tests done: Build the EB, there was no issue.

Tracked-On: OAM-127806

@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@sysopenci sysopenci added Pending PR Review Pending PR Review Engineering Build Not Started Engineering Build Not Started Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Jan 16, 2025
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

2 similar comments
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

1 similar comment
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@ankithbti52509 ankithbti52509 changed the title Updated Composer3 HAL. BSP_DIFF cleanup Jan 16, 2025
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

3 similar comments
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci sysopenci added Pending Developer Approval Pending Developer Approval and removed Developer Approved labels Jan 16, 2025
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

1 similar comment
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci sysopenci added Developer Approved and removed Pending Developer Approval Pending Developer Approval labels Jan 16, 2025
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

2 similar comments
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

one of the dependent pr's program name is not compatable with other dependent prs, for more details please check tracked_on

@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

1 similar comment
@sysopenci
Copy link

one of the dependent pr cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci sysopenci added Engineering Build Successful Engineering Build Successful and removed Engineering Build Not Started Engineering Build Not Started labels Jan 17, 2025
shyjumon-n
shyjumon-n approved these changes Jan 17, 2025
View reviewed changes
Copy link

@shyjumon-n shyjumon-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysopenci
Copy link

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details.

@sysopenci
Copy link

SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details.

@ankithbti52509
Updated Composer3 HAL.
c33abf1 
Updating android.hardware.graphics.composer3 hal version from V2 to V4.
Also adding new apis as per hal version.

Tests done: Build the EB, there is no issue.

Tracked-On: NA
Signed-off-by: Tekriwal, Tanuj <[email protected]>
Signed-off-by: Ankit Agrawal <[email protected]>
@sysopenci
Copy link

Improper Commit Message
Proper Tracked on value is not present in
commit message,make sure Tracked-on: jira-ticket is present

@sysopenci
Copy link

This pull request cannot be Rebase and Merged; please fix the issue and commit your changes once again to run EB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyjumon-n shyjumon-n shyjumon-n approved these changes

@feijiang1 feijiang1 Awaiting requested review from feijiang1

@gkdeepa gkdeepa Awaiting requested review from gkdeepa

@renchenglei renchenglei Awaiting requested review from renchenglei

@yaoxinshi-intel yaoxinshi-intel Awaiting requested review from yaoxinshi-intel

@YuanjunHuang YuanjunHuang Awaiting requested review from YuanjunHuang

@yyao3 yyao3 Awaiting requested review from yyao3

Assignees
No one assigned
Labels
Developer Approved Engineering Build Successful Engineering Build Successful Invalid commit message Pending PR Review Pending PR Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankithbti52509 @sysopenci @shyjumon-n