Fixed some coverity issues

* Double free * Double close Tracked-On: OAM-129205 Signed-off-by: manxiaoliang <[email protected]>
projectceladon · Feb 19, 2025 · c4ffd6a · c4ffd6a
1 parent 455f216
commit c4ffd6a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cros_gralloc/cros_gralloc_driver.cc b/cros_gralloc/cros_gralloc_driver.cc
@@ -205,8 +205,6 @@ cros_gralloc_driver::cros_gralloc_driver(): drivers_(GPU_GRP_TYPE_NR, nullptr)
 
 		// hit any of undesired render node
 		if (j < ARRAY_SIZE(undesired)) {
-			drmFreeVersion(version);
-			close(fd);
 			continue;
 		}
 

diff --git a/xe.c b/xe.c
@@ -428,6 +428,8 @@ static int xe_init(struct driver *drv)
 
 	if (!xe_query_device_info(drv, xe)) {
 		drv_loge("Failed to query device id using DRM_IOCTL_XE_DEVICE_QUERY");
+		if (!xe)
+			free(xe);
 		return -EINVAL;
 	}