Update HTTPRequestRedirectPolicy tests to use RedirectResponseCode

Signed-off-by: Billy Schulze <[email protected]>
projectcontour · Nov 26, 2024 · f4e4e33 · f4e4e33
1 parent 4af6a40
commit f4e4e33
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/apis/projectcontour/v1/zz_generated.deepcopy.go b/apis/projectcontour/v1/zz_generated.deepcopy.go
diff --git a/internal/dag/builder_test.go b/internal/dag/builder_test.go
@@ -12395,7 +12395,7 @@ func TestDAGInsert(t *testing.T) {
 								Scheme:     ptr.To("https"),
 								Hostname:   ptr.To("envoyproxy.io"),
 								Port:       ptr.To(int32(443)),
-								StatusCode: ptr.To(301),
+								StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 							},
 						}},
 					},
@@ -12438,7 +12438,7 @@ func TestDAGInsert(t *testing.T) {
 								Scheme:     ptr.To("https"),
 								Hostname:   ptr.To("envoyproxy.io"),
 								Port:       ptr.To(int32(443)),
-								StatusCode: ptr.To(301),
+								StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 							},
 						}},
 					},
@@ -12490,7 +12490,7 @@ func TestDAGInsert(t *testing.T) {
 								Scheme:     ptr.To("https"),
 								Hostname:   ptr.To("envoyproxy.io"),
 								Port:       ptr.To(int32(443)),
-								StatusCode: ptr.To(301),
+								StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 							},
 						}},
 					},
@@ -12643,7 +12643,7 @@ func TestDAGInsert(t *testing.T) {
 									Scheme:     ptr.To("https"),
 									Hostname:   ptr.To("envoyproxy.io"),
 									Port:       ptr.To(int32(443)),
-									StatusCode: ptr.To(301),
+									StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 								},
 							},
 						},

diff --git a/internal/dag/httpproxy_processor.go b/internal/dag/httpproxy_processor.go
@@ -1951,7 +1951,7 @@ func redirectRoutePolicy(redirect *contour_v1.HTTPRequestRedirectPolicy) (*Redir
 
 	var statusCode int
 	if redirect.StatusCode != nil {
-		statusCode = *redirect.StatusCode
+		statusCode = int(*redirect.StatusCode)
 	}
 
 	if redirect.Path != nil && redirect.Prefix != nil {

diff --git a/internal/featuretests/v3/redirectroutepolicy_test.go b/internal/featuretests/v3/redirectroutepolicy_test.go
@@ -43,7 +43,7 @@ func TestRedirectResponsePolicy_HTTProxy(t *testing.T) {
 					Scheme:     ptr.To("https"),
 					Hostname:   ptr.To("envoyproxy.io"),
 					Port:       ptr.To(int32(443)),
-					StatusCode: ptr.To(301),
+					StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 					Path:       ptr.To("/blog"),
 				},
 			}},
@@ -87,7 +87,7 @@ func TestRedirectResponsePolicy_HTTProxy(t *testing.T) {
 					Scheme:     ptr.To("https"),
 					Hostname:   ptr.To("envoyproxy.io"),
 					Port:       ptr.To(int32(443)),
-					StatusCode: ptr.To(301),
+					StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 					Prefix:     ptr.To("/blogprefix"),
 				},
 			}},
@@ -135,7 +135,7 @@ func TestRedirectResponsePolicy_HTTProxy(t *testing.T) {
 					Scheme:     ptr.To("https"),
 					Hostname:   ptr.To("envoyproxy.io"),
 					Port:       ptr.To(int32(443)),
-					StatusCode: ptr.To(301),
+					StatusCode: ptr.To(contour_v1.RedirectResponseCode(301)),
 					Prefix:     ptr.To("/blogprefix"),
 					Path:       ptr.To("/blogprefix"),
 				},