Replace GRPC state of world updates with ADS Delta

changelogs/unreleased/6806-saley89-minor.md

@@ -0,0 +1,6 @@
+## Replace GRPC state of world updates with ADS Delta
+
+The mechanism used for xDS updates between Contour and Envoy has been changed from standard `GRPC` (aka "state of the world" updates) to
+[Aggregated Discovery Service](https://www.envoyproxy.io/docs/envoy/latest/configuration/overview/xds_api#aggregated-discovery-service) (ADS) `Delta GRPC` updates. This change is a part of the ongoing effort to improve the performance and scalability of Contour.
+With this mechanism in place Contour will now send only the changes to Envoy, instead of the entire state of the world on every update. Additionally, using ADS allows all the communication to be delivered on a single, bidirectional gRPC stream. 
+Together these changes drastically reduce the cpu and memory footprint of Contour and Envoy, and improve the overall performance of the system allowing for greater numbers of HttpProxies in a single cluster.

internal/envoy/v3/auth.go

@@ -31,7 +31,7 @@ func UpstreamTLSContext(peerValidationContext *dag.PeerValidationContext, sni st
 	if clientSecret != nil {
 		clientSecretConfigs = []*envoy_transport_socket_tls_v3.SdsSecretConfig{{
 			Name:      envoy.Secretname(clientSecret),
-			SdsConfig: ConfigSource("contour"),
+			SdsConfig: ConfigSource(),
 		}}
 	}
 
@@ -125,7 +125,7 @@ func DownstreamTLSContext(serverSecret *dag.Secret, tlsMinProtoVersion, tlsMaxPr
 			},
 			TlsCertificateSdsSecretConfigs: []*envoy_transport_socket_tls_v3.SdsSecretConfig{{
 				Name:      envoy.Secretname(serverSecret),
-				SdsConfig: ConfigSource("contour"),
+				SdsConfig: ConfigSource(),
 			}},
 			AlpnProtocols: alpnProtos,
 		},

internal/envoy/v3/bootstrap.go

@@ -169,7 +169,7 @@ func bootstrapConfig(c *envoy.BootstrapConfig) *envoy_config_bootstrap_v3.Bootst
 					LayerSpecifier: &envoy_config_bootstrap_v3.RuntimeLayer_RtdsLayer_{
 						RtdsLayer: &envoy_config_bootstrap_v3.RuntimeLayer_RtdsLayer{
 							Name:       DynamicRuntimeLayerName,
-							RtdsConfig: ConfigSource("contour"),
+							RtdsConfig: ConfigSource(),
 						},
 					},
 				},
@@ -187,8 +187,15 @@ func bootstrapConfig(c *envoy.BootstrapConfig) *envoy_config_bootstrap_v3.Bootst
 			},
 		},
 		DynamicResources: &envoy_config_bootstrap_v3.Bootstrap_DynamicResources{
-			LdsConfig: ConfigSource("contour"),
-			CdsConfig: ConfigSource("contour"),
+			AdsConfig: &envoy_config_core_v3.ApiConfigSource{
+				ApiType:             envoy_config_core_v3.ApiConfigSource_DELTA_GRPC,
+				TransportApiVersion: envoy_config_core_v3.ApiVersion_V3,
+				GrpcServices: []*envoy_config_core_v3.GrpcService{
+					GrpcService("contour", "", timeout.DefaultSetting()),
+				},
+			},
+			LdsConfig: ConfigSource(),
+			CdsConfig: ConfigSource(),
 		},
 		StaticResources: &envoy_config_bootstrap_v3.Bootstrap_StaticResources{
 			Clusters: []*envoy_config_cluster_v3.Cluster{{