experimental: feat(VoiceConnection): lower browser runtime error to a warning #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
added
scope: voice
TTtie
force-pushed
the
experimental/browser-voice
branch
from
b36c852 to
be9a700
Compare
TTtie
force-pushed
the
experimental/browser-voice
branch
from
be9a700 to
7a389a8
Compare
TTtie
force-pushed
the
experimental/browser-voice
branch
from
7a389a8 to
3031c88
Compare
The base work around "browser" support was done over 7 years ago. Although nothing much has changed when it comes to supporting UDP connections in browsers, over time, browser-like runtimes like Deno, Bun, and others claiming (partial) Node compatibility (including UDP connections) have emerged. Although using Dysnomia with these browser- -like environments won't be officially supported, I think that rather than blocking them outright, we should acknowledge that those alternative runtimes exist and allow them to try to use voice at their own risk with a warning that they might possibly end up seeing undefined or weird behavior.
TTtie
force-pushed
the
experimental/browser-voice
branch
from
3dc40a6 to
a0dd5e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base work around "browser" support was done over 7 years ago. Although nothing much has changed when it comes to supporting UDP connections in browsers, over time, browser-like runtimes like Deno, Bun, and others claiming (partial) Node compatibility (including UDP connections) have emerged. Although using Dysnomia with these browser-like environments won't be officially supported, I think that rather than blocking them outright, we should acknowledge that those alternative runtimes exist and allow them to try to use voice at their own risk with a warning that they might possibly end up seeing undefined or weird behavior.