Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc links. #354

Merged
merged 1 commit into from
May 5, 2024
Merged

Fix doc links. #354

merged 1 commit into from
May 5, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

One link was broken and the other was using the old HTML style links.

One link was broken and the other was using the old HTML style
links.
Copy link
Collaborator

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one more for the books as soon as the safe-harbor release gets tagged.

By the way to make changelog generation easier I'd really like to start using and even enforcing conventional commits so that I can use something like git-cliff for future release cycles. The conventional spec can be a bit ugly/inflexible/wordy at times but the tooling support is way better than anything else out there. I already had to come through 2 years of commits to hand write the safe harbor release notes and the commit messages are only partially useful. Would you mind prefixing this commit message with docs: ...?

@alerque alerque merged commit 319dd19 into projectfluent:main May 5, 2024
5 checks passed
@alerque
Copy link
Collaborator

alerque commented May 5, 2024

Since this was a single-commit PR anyway I just squashed-merged it so I could fix the commit message in the process.

@waywardmonkeys waywardmonkeys deleted the fix-doc-links branch May 6, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants