-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from gitbook to mdbook #363
Conversation
The current rendering is available here: https://test.flod.org/tmp_guide/ |
.nojekyll
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this added? AFAIK, there are no files or directories starting with an underscore in the mdbook results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had other errors (again, a long time time ago). Since we don't use Jekyll, I tend to leave it there and disable it.
package.json
Outdated
@@ -40,8 +40,7 @@ | |||
"eslint": "^6.7.2", | |||
"@fluent/bundle": "^0.14.0", | |||
"@fluent/syntax": "^0.14.0", | |||
"gh-pages": "^2.1.1", | |||
"gitbook-cli": "^2.3.2", | |||
"gh-pages": "^6.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably drop this and the npm run deploy
script, if/as we're going to presume that the action will take care of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this and the deploy action, but I didn't run any npm command (as said, I'd prefer for someone who understands JS to do that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test the changes you suggested on another repo
.nojekyll
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had other errors (again, a long time time ago). Since we don't use Jekyll, I tend to leave it there and disable it.
Fixes #256