[#106] Make sure our paths in fixtures contain utf8 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems our code itself is perfectly able to deal with unicode paths. However, when creating an sqlachemy sqlite engine with an unicode path |
elbenfreund
force-pushed
the
feature/#106-Ensure_unicode_appdirs_are_ok
branch
from
71d55c0
to
21135e6
Compare
Current coverage is 97.33%@@ develop #161 diff @@
==========================================
Files 3 3
Lines 372 374 +2
Methods 0 0
Messages 0 0
Branches 33 33
==========================================
+ Hits 362 364 +2
Misses 6 6
Partials 4 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to have confidence in our ability to handle utf8 path location
we just add random utf8 string named sub-dirs to our path fixtures.
Closes: #106