Fix notifications

[sh-zam]

This should most make the notifications work like it worked in past. (However, it doesn't use the pynotify).

There is one issue, the path to the icon is hardcoded. I am not sure, if we can dynamically access the installed location of hamster or the "future" installation structure of hamster.

CC: issue#493

[ederag]

Thanks, this looks very interesting.
But for reasons explained in #493, this should be external (not in hamster itself):

All these features can be implemented separately,
talking to the main hamster through dbus, for instance.

Please do ask there for any clarifications.

The next weeks free time will be devoted to finalizing v3.0,
only then will I be able to help setting up an external service.

Meanwhile, please do keep this PR open.
If you merge master into it regularly, people will be able to use it (instructions),
until the external companion is up and running.

About the icon location, the base path can be accessed in defs:

>>> from hamster import defs
>>> defs.DATA_DIR
'/usr/share'

But that's about it. The new icon installation path is set in

hamster/data/wscript_build

Lines 7 to 14 in a572ddc

	bld.install_files('${DATADIR}/hamster/art', start_dir.ant_glob('art/*.png'))
	bld.install_files('${DATADIR}/hamster', 'report_template.html')
	bld.install_files('${DATADIR}/icons/hicolor/16x16/apps', 'art/16x16/hamster.png')
	bld.install_files('${DATADIR}/icons/hicolor/22x22/apps', 'art/22x22/hamster.png')
	bld.install_files('${DATADIR}/icons/hicolor/32x32/apps', 'art/32x32/hamster.png')
	bld.install_files('${DATADIR}/icons/hicolor/48x48/apps', 'art/scalable/hamster.png')
	bld.install_files('${DATADIR}/icons/hicolor/scalable/apps','art/scalable/hamster.svg')

The directory and names changed in #485,
so beware that it seems to work on your system because of remnants from a previous installation.

There should be a better way though, for instance in the ui, icons can be found by name:

hamster/data/edit_activity.ui

Line 18 in a572ddc

<property name="icon_name">hamster</property>

[ederag]

There will never be any CLA on this code. Please disregard the wrong checks (#589).

[sh-zam]

I have updated this to the current master and I have updated the way to get icon path, however I am not sure if this is how you're supposed to do it.

[mwilck]

The code looks good in general.

I'd like to understand how it relates to the previous code removed in 08eaf77 (desktop.py). Have you used that code as a template / reference somehow? You seem to have implemented some things differently (looking at the actual Notify() code for example - missing transient and urgency properties), could you elaborate a bit on that, either in the commit message or in comments in the code?

[mwilck]

notifs_mgr seems to be referenced nowhere in this file. What am I missing?

[sh-zam]

Must be remnants of my debugging session. I'll remove it, thanks!

[sh-zam]

Thank you for reviewing!

I'd like to understand how it relates to the previous code removed in 08eaf77 (desktop.py). Have you used that code as a template / reference somehow?

No, I did not I'm afraid. I wrote it from scratch by looking at the docs :(

You seem to have implemented some things differently (looking at the actual Notify() code for example - missing transient and urgency properties), could you elaborate a bit on that, either in the commit message or in comments in the code?

I didn't know that such a thing (transient) existed. I will update my patch to include it and add a few comments along the way.

PS: Just yesterday, I added code to close notifications automatically. It was an ugly hack. Thanks for mentioning transient :-)