-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epstein civil violence: Switch to experimental datacollector #158
base: main
Are you sure you want to change the base?
Conversation
"Cops": self.count_cops, | ||
} | ||
agent_reporters = { | ||
"x": lambda agents: [pos[0] for pos in agents.get("pos")], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API is awkward. It is better to use instead lambda a: a.pos[0]
. But this means AgentSet
needs to have the feature of .apply()
along the line of DataFrame's apply.
This also means that the new DataCollector
heavily relies on AgentSet
in order to remain simple. Simple is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @quaquel was also thinking in this direction: projectmesa/mesa#1944 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am back in office and do have some time. However, I lot has been happening wrt to MESA so @EwoutH if you have 30 minutes to bring me up to speed, I am happy to take a look at the apply idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to hear! Let me get back to you what works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quaquel would tomorrow early afternoon work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, just email me a time and place (online or my office)
No description provided.