Fix data paths and model passing in GIS examples #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
City uses a RasterLayer, which needs a model as input as of mesa-geo 0.8.0.
UrbanCell uses a Cell, which needs a model as input as of mesa-geo 0.8.0.
Agents always need a Model object to be able to use Model variables and properties, including the AgentSet.
for more information, see https://pre-commit.ci
|
This PR brings the score for the 7 gis examples from 2 fully passed and 1 passed with warnings, to 3 fully passed and 3 passes with warnings. |
Fix the model by passing the model object correctly
Fix the model by passing the model object correctly
|
Another two models pass. 5 pass, one warning, one fail. Those will be separate PRs. This one is ready for review. |
rht
reviewed
Aug 26, 2024
pathlib.Path improves over the older os.path methods by providing a more modern, object-oriented interface for working with filesystem paths. As can be seen, it reduces the code complexity a bit.
|
I noticed one other issue: But that isn't fixable from the examples alone, so something for @wang-boyu or @tpike3 to look into. I updated the tracking issues #172. Going to merge this PR. |
This was referenced Sep 1, 2024
EwoutH
added a commit
to EwoutH/mesa-examples
that referenced
this pull request
Sep 3, 2024
This commit addresses several of the remaining issues across the GIS examples: - Corrects data file paths in the population, rainfall, and urban growth models to use relative paths from the script directory. - Fixes the urban growth model by passing the model object to City and UrbanCell classes, as required by mesa-geo 0.8.0. - Updates the population model to pass the model object when creating agents, ensuring they can access Model variables and properties. - Corrects the use of `/vsigzip/` paths for GDAL compatibility. The `/vsigzip/` situation is super weird. It isn't part of the file path, but it's a "marker" a GDAL convention. See the PR message, mesa-geo#235 and https://gdal.org/user/virtual_file_systems.html#vsigzip-gzipped-file for more details.
EwoutH
added a commit
to EwoutH/mesa-examples
that referenced
this pull request
Sep 20, 2024
This commit addresses several of the remaining issues across the GIS examples: - Corrects data file paths in the population, rainfall, and urban growth models to use relative paths from the script directory. - Fixes the urban growth model by passing the model object to City and UrbanCell classes, as required by mesa-geo 0.8.0. - Updates the population model to pass the model object when creating agents, ensuring they can access Model variables and properties. - Corrects the use of `/vsigzip/` paths for GDAL compatibility. The `/vsigzip/` situation is super weird. It isn't part of the file path, but it's a "marker" a GDAL convention. See the PR message, mesa-geo#235 and https://gdal.org/user/virtual_file_systems.html#vsigzip-gzipped-file for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several of the remaining issues across the GIS examples:
/vsigzip/paths for GDAL compatibility.The
/vsigzip/situation is super weird. It isn't part of the file path, but it's a "marker" a GDAL convention. See projectmesa/mesa-geo#235 for more details.Part of #172.