remove unique_id and model.next_id #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
approved these changes
Sep 5, 2024
examples/boltzmann_wealth_model/boltzmann_wealth_model/model.py
Outdated
Show resolved
Hide resolved
examples/boltzmann_wealth_model_network/boltzmann_wealth_model_network/model.py
Show resolved
Hide resolved
There was a problem hiding this comment.
In this notebook, why is the scheduler added back?
There was a problem hiding this comment.
I did not change anything there
There was a problem hiding this comment.
Unfortunately the diff says otherwise. Could it be you started on an outdated branch?
I reverted it, that example is one big mess by the way.
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
…_network/model.py Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
Co-authored-by: Ewout ter Hoeven <[email protected]>
EwoutH
added a commit
to EwoutH/mesa-examples
that referenced
this pull request
Sep 20, 2024
All examples can be updated to no longer pass a unique id, nor use model.next_id. This only fixes the examples, not the gis-examples or rl examples. Co-authored-by: Ewout ter Hoeven <[email protected]>
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2260 merged, all examples can be updated to no longer pass a unique id, nor use model.next_id.
This only fixes the examples, not the gis-examples or rl examples.