Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update license with year and contributors #86

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

wang-boyu
Copy link
Member

Partly addresses #46.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #86 (4248933) into master (0bdbad6) will decrease coverage by 7.10%.
The diff coverage is 71.85%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   85.67%   78.57%   -7.11%     
==========================================
  Files           5        7       +2     
  Lines         363      574     +211     
  Branches       57       97      +40     
==========================================
+ Hits          311      451     +140     
- Misses         37      107      +70     
- Partials       15       16       +1     
Impacted Files Coverage Δ
mesa_geo/geospace.py 84.84% <67.56%> (-3.42%) ⬇️
mesa_geo/geoagent.py 78.94% <70.00%> (+0.78%) ⬆️
mesa_geo/raster_layers.py 70.27% <70.27%> (ø)
mesa_geo/geo_base.py 76.92% <76.92%> (ø)
mesa_geo/visualization/modules/MapVisualization.py 89.28% <84.61%> (+5.50%) ⬆️
mesa_geo/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7fe7cb...4248933. Read the comment docs.

@rht
Copy link
Contributor

rht commented Jul 19, 2022

What happened to the codecov diff?

@rht
Copy link
Contributor

rht commented Jul 19, 2022

I think they updated the way they calculate the coverage?

@wang-boyu
Copy link
Member Author

@rht
Copy link
Contributor

rht commented Jul 20, 2022

I will just merge this PR.

@rht rht merged commit b742f89 into projectmesa:master Jul 20, 2022
@wang-boyu wang-boyu deleted the license-update branch July 21, 2022 01:14
@wang-boyu
Copy link
Member Author

Looks like the base commit that Codecov is comparing against is wrong. I'll work on my next PR as usual and see if we can get the correct base commit then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants