-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make experimental cell spaces work with PropertyGrid #2068
Conversation
Performance benchmarks:
|
Thanks for the PR! I'm quite busy, I hope to be able to review it this weekend. |
Thanks for this PR! It looks quite good, I just think the link between cells and the properties should be established directly when a property layer is added (and removed if it is removed). So you don't need to implement another select_random_empty_cell method. Otherwise some tests would be great, but not strictly required for this to be merged. |
removed method select_random_empty_cell from new _PropertyGrid in cell space
Starts looking good! I would like to have some unittests in here: https://github.com/projectmesa/mesa/blob/main/tests/test_cell_space.py You can probably recycle some of these tests: Line 611 in de24299
|
@haleelsada would you be able to write the unittests? |
@EwoutH Thanks for keeping up with this! |
@haleelsada are you okay if I write the unittests and add them to this PR? Or do you still want to do this? @tpike3 No problem! Could you maybe keep a bit track of the visualisation direction and PRs? I am not that familiar with that part of the codebase. |
This PR marks the initial stride towards addressing the issue of integrating experimental cell spaces with PropertyGrid functionality #2059. I have added the PropertyGrid class and kept two methods remove_property_layer, add_property_layer and improved select_random_empty_cell from parent class in experimental.cell_space.grid.py .
The submitted changes represent the initial phase of the requested updates, and I am eager to refine them further based on any feedback received to ensure completion of the necessary modifications.
Sample code: