Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize PropertyLayers #2336
Visualize PropertyLayers #2336
Changes from all commits
9ebdfbb
8b34f9e
cb4a238
1b1dedd
a7dbe0a
593004b
381cb03
7c8e98b
6e61813
f938bd8
e6d7cb9
e2e0c43
a7e45cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 56 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: s/Why not use the space/Why not remove the space/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review and the questions, I will try to look into them soon.
Also feel free to open a PR if you already have concrete solutions in mind.
Edit: Yeah I now remind, there are some inconsistencies between the draw functions here. When I add support for other spaces I will try to address these.
Check warning on line 58 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L58
Check warning on line 60 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L60
Check warning on line 64 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L64
Check warning on line 79 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L79
Check warning on line 81 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L81
Check warning on line 84 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L83-L84
Check warning on line 87 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L87
Check warning on line 97 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L94-L97
Check warning on line 106 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L101-L106
Check warning on line 109 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L109
Check warning on line 118 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L115-L118
Check warning on line 121 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L121
Check warning on line 124 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L123-L124
Check warning on line 134 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L134
Check warning on line 136 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L136
Check warning on line 143 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L143
Check warning on line 145 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L145
Check warning on line 149 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L147-L149
Check warning on line 153 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L153
Check warning on line 155 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L155
Check warning on line 160 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L160
Check warning on line 163 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L163
Check warning on line 165 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L165
Check warning on line 174 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L167-L174
Check warning on line 222 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L222
Check warning on line 336 in mesa/visualization/components/matplotlib.py
Codecov / codecov/patch
mesa/visualization/components/matplotlib.py#L336