Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visualization modules from mesa.experimental #2495

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Nov 11, 2024

This removes visualization modules from mesa.experimental.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🟢 -7.5% [-8.8%, -6.1%] 🔵 -2.4% [-2.6%, -2.2%]
BoltzmannWealth large 🔵 -2.3% [-3.2%, -1.5%] 🟢 -7.4% [-8.9%, -5.7%]
Schelling small 🔵 -2.4% [-2.7%, -2.1%] 🔵 -2.3% [-2.4%, -2.1%]
Schelling large 🔵 -3.2% [-4.0%, -2.4%] 🟢 -6.0% [-6.7%, -5.5%]
WolfSheep small 🔵 -1.9% [-2.2%, -1.6%] 🔵 -1.6% [-1.8%, -1.4%]
WolfSheep large 🔵 -2.5% [-3.2%, -1.9%] 🟢 -8.8% [-10.2%, -7.3%]
BoidFlockers small 🔵 -0.1% [-0.6%, +0.4%] 🔵 -1.4% [-1.9%, -0.9%]
BoidFlockers large 🔵 +0.9% [+0.4%, +1.6%] 🔵 -1.1% [-1.8%, -0.4%]

@EwoutH
Copy link
Member

EwoutH commented Nov 11, 2024

Had already a draft branch, thanks! Will review after diner.

@EwoutH
Copy link
Member

EwoutH commented Nov 11, 2024

The whole components folder can also be removed, right?

@quaquel
Copy link
Member Author

quaquel commented Nov 11, 2024

The whole components folder can also be removed, right?

good point, I now have removed those as well.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EwoutH EwoutH merged commit c2c406f into projectmesa:main Nov 11, 2024
10 of 11 checks passed
@quaquel quaquel deleted the remove_solaraviz branch November 14, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants