-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update camelcase to v7.x #5346
Update camelcase to v7.x #5346
Conversation
* Fixed import for new version of camelcase by moving from top level into method body. This allows to suppress ERR_REQUIRE_ESM error.
Codecov ReportBase: 83.95% // Head: 83.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5346 +/- ##
==========================================
- Coverage 83.95% 83.77% -0.19%
==========================================
Files 30 48 +18
Lines 1471 1793 +322
Branches 257 346 +89
==========================================
+ Hits 1235 1502 +267
- Misses 170 214 +44
- Partials 66 77 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the release notes of v7 have:
This package is now pure ESM. Please read this.
wondering: have we tried the suggested approach already?
i am no JS/node expert but i am guessing the suggested "fix" might not actually work, we just happen to not process .svg
files as part of our build, so the import doesnt get executed now.
Exactly. Looks like the code in |
just to be clear: imo it doesnt make sense to upgrade this library and fix new problems by avoiding its usage... unless we find an easy way to fix the import "correctly" or we are planning to migrate the project to ESM completely (which might not be a good use of our time right now), we should imo just not bother upgrading the library for now... |
It is fine to close this PR, since I didn't find a way to use import for this module correctly. Can we somehow prevent bot updating this version ? |
i think closing the original PR will mark it as ignored/blocked in the dependency dashboard: |
I'm okay with closing (and not yet bothering about the dependency update). |
This branch is based on #5305.
In this PR:
camelcase
by moving it from top level into method body. This allows to suppress ERR_REQUIRE_ESM error.