Nit: Make function to build a Basic Authorization header publicly available (for internal use) #9578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable (for internal use)
|
This is a prerequisite for #9553 |
dimas-b
reviewed
Sep 19, 2024
| private BasicAuthentication(String username, String password) { | ||
| String header = basicHeader(username, password); | ||
| String header = basicAuthorizationHeader(username, password); |
There was a problem hiding this comment.
Why expose an auth scheme that is deprecated in Nessie in public API? Maybe add an internal utility class for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.