Persist: Enable reference-cache by default #9760
Open
+34
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
ref-cache-enable-default
branch
2 times, most recently
from
4e93232 to
f66a447
Compare
snazy
force-pushed
the
ref-cache-enable-default
branch
from
f66a447 to
7a48740
Compare
Default cache TTL is 5 minutes.
snazy
force-pushed
the
ref-cache-enable-default
branch
from
7a48740 to
b8bedf0
Compare
dimas-b
reviewed
Dec 4, 2024
dimas-b
reviewed
Dec 4, 2024
Comment on lines
+59
to
+63
| - If you are not using k8s and you are running Nessie with multiple nodes, you must either | ||
| * configure `nessie.version.store.persist.cache-invalidations.service-names`, see | ||
| [docs reference](https://projectnessie.org/nessie-latest/configuration/#version-store-advanced-settings), | ||
| or | ||
| * disable the reference cache by setting `nessie.version.store.persist.reference-cache-ttl` to `PT0S`. |
There was a problem hiding this comment.
What's the benefit of enabling reference cache by default if users have to do additional config changes to run Nessie now?
There was a problem hiding this comment.
That's only if you run multiple nodes without k8s
There was a problem hiding this comment.
But is reference cache critical for single-node deployments?
"Must" is a strong word. It looks like the new default is going to cause undue failures for naive users when they scale Nessie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default cache TTL is 5 minutes.