Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logrotate wildcard #73

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: logrotate wildcard #73

merged 1 commit into from
Sep 30, 2024

Conversation

fadnincx
Copy link
Collaborator

Description

Should fix the logrotate issue described in #72

Fixes #72

Dependencies

N/A

@nis65
Copy link
Collaborator

nis65 commented Sep 26, 2024

When doing the bug report, I tested on my local machine with {{ potos_basics_ansible_logdir }}/*log { and not .../*.log so my test would have caught files named syslog too and not only sys.log (silly example, I know).

But good for me like that :-)

Copy link
Collaborator

@nis65 nis65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nis65
Copy link
Collaborator

nis65 commented Sep 26, 2024

Hi @fadnincx I tried to approve, but as I don't have write access, my "approval" seems not to count... 🤷

@fadnincx
Copy link
Collaborator Author

Hi @fadnincx I tried to approve, but as I don't have write access, my "approval" seems not to count... 🤷

As a regular contributor, I gave you now more permissions on this repo. Your approval now counts.

@fadnincx fadnincx merged commit a2bf6dc into main Sep 30, 2024
0 of 4 checks passed
@fadnincx fadnincx deleted the fix/logrotate branch September 30, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: logrotate config is flawed
2 participants