-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate component renovate.json
in post-gen-project hook
#106
Conversation
00286c4
to
7c6ac0f
Compare
Note that this changes the JSON layout a bit: --- base/renovate.json 2024-06-06 13:45:07.245014870 +0200
+++ feat/renovate.json 2024-06-06 13:47:36.637434662 +0200
@@ -11,17 +11,23 @@
"commands": [
"make gen-golden-all"
],
- "fileFilters": [ "tests/golden/**" ],
+ "fileFilters": [
+ "tests/golden/**"
+ ],
"executionMode": "update"
},
- "suppressNotifications": [ "artifactErrors" ],
+ "suppressNotifications": [
+ "artifactErrors"
+ ],
"labels": [
"dependency"
],
"separateMinorPatch": true,
"packageRules": [
{
- "matchUpdateTypes": ["patch"],
+ "matchUpdateTypes": [
+ "patch"
+ ],
"matchCurrentVersion": "!/^v?0\\./",
"automerge": true,
"platformAutomerge": false, |
7c6ac0f
to
10827f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should move the whole renovate.json
dict into python?
I've considered that, but I'm not sure if having the whole |
follow-up: see ebd82f5 for a draft implementation which fully generates the After staring at it for a bit, I think I'll use that version (+ a note in the template repo README to reduce confusion levels if someone wants to adjust the templated |
renovate.json
in post-gen-project hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like that we now can add comments as we like 👍
We expect that writing more complex package rules as Jinja2 templates in JSON will quickly become unreadable, so we move generating the component's
renovate.json
to the template's pos-gen-project Python hook where we can generate the desired package rules and other conditional configurations more easily.Follow-up to #101
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.