Skip to content

Commit

Permalink
Merge pull request #29 from projectsyn/switch-to-new-embedded-helm-be…
Browse files Browse the repository at this point in the history
…st-practices

Switch to new Helm best practice format
  • Loading branch information
bastjan authored Jun 21, 2022
2 parents 2c59612 + c8f77cc commit 7286a96
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
4 changes: 3 additions & 1 deletion class/defaults.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ parameters:
secretname: metallb-memberlist
configmap_name: metallb
charts:
metallb: 0.12.1
metallb:
source: https://metallb.github.io/metallb
version: 0.12.1
8 changes: 4 additions & 4 deletions class/metallb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ parameters:
kapitan:
dependencies:
- type: helm
output_path: dependencies/metallb/helmcharts/metallb-${metallb:charts:metallb}
source: https://metallb.github.io/metallb
version: ${metallb:charts:metallb}
output_path: dependencies/metallb/helmcharts/metallb-${metallb:charts:metallb:version}
source: ${metallb:charts:metallb:source}
version: ${metallb:charts:metallb:version}
chart_name: metallb
compile:
- input_paths:
Expand All @@ -19,7 +19,7 @@ parameters:
input_type: helm
output_type: yaml
input_paths:
- metallb/helmcharts/metallb-${metallb:charts:metallb}
- metallb/helmcharts/metallb-${metallb:charts:metallb:version}
helm_values:
speaker:
secretName: ${metallb:speaker:secretname}
Expand Down
8 changes: 4 additions & 4 deletions docs/modules/ROOT/pages/references/parameters.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ For example this allows to specify multiple address pools:
See the https://metallb.universe.tf/configuration/[MetalLB documentation] for more details.


== `charts.metallb`
== `charts.metallb.version`

[horizontal]
type:: helm chart version
default:: 1.1.0
type:: string
default:: See https://github.com/projectsyn/component-metallb/blob/master/class/defaults.yml[class/defaults.yml]

A specific chart version. See the https://kapitan.dev/external_dependencies/#helm-type[kapitan documentation] for more information.
The version of the `metallb` chart that's used.

0 comments on commit 7286a96

Please sign in to comment.