Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore changes to CRD conversion webhook CA bundles #57

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jul 12, 2024

The metallb controller manages that field, so we need to ensure that those changes aren't reverted by ArgoCD.

This PR configures ArgoCD to ignore changes to the conversion webhook CA bundles.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@simu simu added bug Something isn't working bump:patch labels Jul 12, 2024
@simu simu requested a review from haasad July 12, 2024 08:58
Copy link

github-actions bot commented Jul 12, 2024

🚀 This PR has been released as v4.0.1

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

@projectsyn projectsyn deleted a comment from github-actions bot Jul 12, 2024
The metallb controller manages that field, so we need to ensure
that those changes aren't reverted by ArgoCD.

This commit configures ArgoCD to ignore changes to the conversion
webhook CA bundles.
@simu simu force-pushed the fix/ignore-crd-conversion-cabundle branch from 3c17de8 to b4e7192 Compare July 12, 2024 09:01
@simu simu merged commit e407581 into master Jul 12, 2024
11 checks passed
@simu simu deleted the fix/ignore-crd-conversion-cabundle branch July 12, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants