Merge version 2024.3.1 from upstream inspector #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: move renovate labels to labeler * chore: add back Renovate's own labeling
* WIP rewriting menus * chore: remove shouldShowFileMenu as it is always true * chore: use individual functions for each option * chore: use role properties where possible, rename some TL keys * chore: use CmdOrCtrl where possible * chore: refactor click * fix: merge callbacks, remove Save option * fix: rename some methods, move Close Window to Mac File * feat: add Edit menu for non-Mac * feat: add Delete option in Edit menu * feat: add Zoom option for Mac Window * feat: add zoom in/out/reset in View menu * fix: add translation keys for new menu options * chore: reuse isDev instead of checking node env again * chore: run Prettier * fix: adjust some translation keys, update docs link, add link to forum * chore: use global vars for window and dev flag * chore: use isMac variable to combine all methods * chore: use arrow functions * chore: fix OS dependent dropdowns * fix: remove non-Mac keyboard nav as it breaks translations * fix: change menu language immediately * fix: add missing translation key * chore: remove unused check * chore: extract URLs as constants * chore: extract more complex methods * chore: merge most options under dropdowns * chore: remove global vars * fix: add check for updates for linux as well * docs: add menu bar documentation * chore: address review comments
Co-authored-by: eglitise <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: eglitise <[email protected]>
…ppium#1371) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
KazuCocoa
approved these changes
Mar 12, 2024
allen-fang
approved these changes
Mar 13, 2024
|
closing this PR since I want to get some more changes in from upstream. |
|
Then, upcoming another fix in the repo would be nice to have |
|
superseded by #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bring in the last month of updates and fixes.