Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation and enum for operational mode. #100

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Oct 14, 2024

Just cleanup and more reliability (feedback when misconfigured).

Copy link

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading "default" as an operational mode, I have no idea what is the behavior 😬. Would it make sense to name it similarly to the others (the actual behavior)?

@bwplotka
Copy link
Member Author

Do you mean in main.go? Fair, will add

@bwplotka bwplotka force-pushed the serve-validation branch 2 times, most recently from 35a9cb8 to fbab3c5 Compare October 14, 2024 10:49
@bwplotka
Copy link
Member Author

Done @ArthurSens

Copy link
Contributor

@jmichalek132 jmichalek132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bwplotka bwplotka merged commit 1e1ee77 into main Oct 14, 2024
7 checks passed
@bwplotka bwplotka deleted the serve-validation branch October 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants